Bug/19092 error should contain human readable message #19251
+4
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
show localized fallback for DIALOG_LOAD_FAILED (ankidroid#19092) Replace the cryptic, technical diagnostic shown to users when DIALOG_LOAD_FAILED is triggered with a fallback message This is a minimal UX-only change that keeps other dialog flows unchanged. ankidroid#19092
Show localized fallback for DIALOG_LOAD_FAILED (ankidroid#19092)
|
First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible. |
|
Important Maintainers: This PR contains Strings changes
|
david-allison
added
the
Needs Author Reply
david-allison
requested changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Replace the cryptic, technical diagnostic shown to users when
DIALOG_LOAD_FAILEDis triggered with a short, localized fallback message. This prevents alarming or confusing error text from being presented in the UI while preserving troubleshooting information in the logs.Fixes
Fixes #19092
Approach
When the dialog type is
DIALOG_LOAD_FAILEDreturn a single localized string resource (R.string.load_failed_fallback_message) instead of the long libanki/sqlite diagnostic text. The change is UI-only: the visible dialog now shows a simple, user-friendly message ("An error occurred. Tap OK to continue using AnkiDroid.").Detailed diagnostics are preserved in code paths (and may still be emitted to the app logs) so developers can debug issues without exposing raw technical output to end users.
Files changed:
Anki-Android/.../DatabaseErrorDialog.kt— returnres().getString(R.string.load_failed_fallback_message)forDIALOG_LOAD_FAILED.03-dialogs.xml— addload_failed_fallback_messagestring resource.