Skip to content
This repository has been archived by the owner on Jun 4, 2022. It is now read-only.

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Fix #334] Add common metadata keys to completion keywords
Browse files Browse the repository at this point in the history
arichiardi committed Jan 25, 2018
1 parent 30179fa commit d51f222
Showing 3 changed files with 6 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -20,6 +20,7 @@
- Don't look for the REPL history file in the user's home directory if one doesn't exist ([#309](https://github.com/anmonteiro/lumo/issues/309)).
- Use `tools.reader` with the unicode literal / cljs.core/bit-or warning ([#341](https://github.com/anmonteiro/lumo/issues/341)).
- Auto-completion fails with numbers in ns names ([#332](https://github.com/anmonteiro/lumo/issues/332))
- Add common metadata keys to completion keywords ([#344](https://github.com/anmonteiro/lumo/issues/344)).

### Changes

5 changes: 4 additions & 1 deletion src/cljs/snapshot/lumo/repl.cljs
Original file line number Diff line number Diff line change
@@ -1337,10 +1337,13 @@
:clj :cljs
:default
:else
:private :doc :author
:gen-class
:keywordize-keys
:req :req-un :opt :opt-un
:args :ret :fn]))
:args :ret :fn
:const
:arglists :tag :static :added]))

(def ^:private namespace-completion-exclusions
(into #{} (map str)
2 changes: 1 addition & 1 deletion src/test/lumo/lumo/repl_tests.cljs
Original file line number Diff line number Diff line change
@@ -65,7 +65,7 @@
(is-completion "" (lumo/completion-candidates false nil)))
(testing "keyword completions"
(is-completion ":" lumo/keyword-completions)
(is-completion ":a" [":args" ":as"])
(is-completion ":a" [":added" ":arglists" ":args" ":as" ":author"])
(is-completion ":ref" [":refer" ":refer-clojure" ":refer-macros"]))
(testing "aliased namespaces completions"
(with-redefs [lumo/current-alias-map (fn []

0 comments on commit d51f222

Please sign in to comment.