Skip to content

fix: pr-standards falsely flags v2-based PRs as missing a linked issue #38408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dondetir wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: pr-standards falsely flags v2-based PRs as missing a linked issue #38408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/pr-standards.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,14 @@ jobs:

const linkedIssues = result.repository.pullRequest.closingIssuesReferences.totalCount;

if (linkedIssues === 0) {
// closingIssuesReferences is only populated for PRs that target the
// default branch, so PRs based on other branches (e.g. v2) would
// always be flagged. Fall back to matching closing keywords in the
// PR body before flagging.
const closingKeyword = /\b(close[sd]?|fix(?:e[sd])?|resolve[sd]?)\b:?\s+#\d+/i;
const bodyReferencesIssue = closingKeyword.test(pr.body ?? '');

if (linkedIssues === 0 && !bodyReferencesIssue) {
await addLabel('needs:issue');
await comment('issue', `Thanks for your contribution!

Expand Down
Loading