fix(app): persist local project renames in project list - #40390
Open
Chewji9875 wants to merge 3 commits into
Open
fix(app): persist local project renames in project list#40390Chewji9875 wants to merge 3 commits into
Chewji9875 wants to merge 3 commits into
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Chewji9875
force-pushed
the
fix-local-project-rename
branch
from
August 4, 2026 10:19
5d50398 to
764cbd6
Compare
Author
|
Hi @Brendonovich @Hona, Updating with additional context on related issues resolved by this PR: This PR addresses and resolves the root causes for several reported issues related to local project renaming, Protocol v2 project metadata persistence, and worktree path resolution:
Whenever you have a moment to review, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #31739
Type of change
What does this PR do?
For projects without a server registration (id-less /
"global"projects), the edit dialog writes the new name, commands, and icon to the per-workspaceprojectMetacache. Butenrich()inglobal.tsxandlayout.tsxonly merged the legacychildStore.iconoverride, so the renamed name and startup command were silently ignored in the project list.This adds a
mergeProjectMetahelper and applies it in bothenrich()functions before the existing icon override. The enriched list is consumed by the sidebar, session tabs, command palette, and directory picker, so local renames now display everywhere. Server-registered projects keep their server values unless a local override exists.How did you verify your code works?
mergeProjectMeta: local name applied for id-less projects, server name kept when local has no name, empty name falls back to the folder-derived name, and icon + commands merge.bun test src/context/global-sync/utils.test.ts: 11 pass (6 existing + 5 new), 0 fail.bun typecheckinpackages/app: 0 errors.OPENCODE_CHANNEL=prod) renders the fix.Screenshots / recordings
this is a display-logic fix on the enriched project list, not a visual UI change. Prior local renames appear once the app rebuilds with this change.
Checklist