Skip to content

Conversation

@felixfontein
Copy link
Collaborator

SUMMARY

The module util was there to apply a bugfix to some older Python versions. Since we're Python 3.7+ only, this is no longer necessary. This also removes the last code from the collection licensed under PSF 2.0.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module util
aix_filesystem

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-12 Automatically create a backport for the stable-12 branch labels Nov 30, 2025
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module module_utils module_utils plugins plugin (any type) labels Nov 30, 2025
@felixfontein felixfontein requested a review from russoz November 30, 2025 14:03
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit d30428a into ansible-collections:main Dec 1, 2025
134 checks passed
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Dec 1, 2025
@patchback
Copy link

patchback bot commented Dec 1, 2025

Backport to stable-12: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply d30428a on top of patchback/backports/stable-12/d30428ac71b78c29dec528d7ec9af5c4383999bc/pr-11232

Backporting merged PR #11232 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible-collections/community.general.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-12/d30428ac71b78c29dec528d7ec9af5c4383999bc/pr-11232 upstream/stable-12
  4. Now, cherry-pick PR Remove no longer needed _mount module util #11232 contents into that branch:
    $ git cherry-pick -x d30428ac71b78c29dec528d7ec9af5c4383999bc
    If it'll yell at you with something like fatal: Commit d30428ac71b78c29dec528d7ec9af5c4383999bc is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x d30428ac71b78c29dec528d7ec9af5c4383999bc
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Remove no longer needed _mount module util #11232 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-12/d30428ac71b78c29dec528d7ec9af5c4383999bc/pr-11232
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the mount branch December 1, 2025 05:43
@felixfontein
Copy link
Collaborator Author

@russoz thanks for reviewing!

felixfontein added a commit to felixfontein/community.general that referenced this pull request Dec 1, 2025
Remove no longer needed _mount module util.

(cherry picked from commit d30428a)
felixfontein added a commit that referenced this pull request Dec 1, 2025
Remove no longer needed _mount module util (#11232)

Remove no longer needed _mount module util.

(cherry picked from commit d30428a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-12 Automatically create a backport for the stable-12 branch bug This issue/PR relates to a bug module_utils module_utils module module plugins plugin (any type)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants