Skip to content

Feature/audit indirect node counting - #696

Merged
SirGitsalot merged 2 commits into
ansible-collections:masterfrom
thekad:feature/audit_indirect_node_counting
Aug 14, 2025
Merged

Feature/audit indirect node counting#696
SirGitsalot merged 2 commits into
ansible-collections:masterfrom
thekad:feature/audit_indirect_node_counting

Conversation

@thekad

@thekad thekad commented Jul 21, 2025

Copy link
Copy Markdown
Collaborator
SUMMARY

Adding indirect node counting query file, refer to extensions/audit/README.md for more info

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

extensions/audit

@codecov

codecov Bot commented Jul 21, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.51%. Comparing base (0bf2444) to head (8a6ffcd).

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #696       +/-   ##
===========================================
+ Coverage   30.15%   61.51%   +31.36%     
===========================================
  Files         179        2      -177     
  Lines       20056      356    -19700     
  Branches     3313       49     -3264     
===========================================
- Hits         6048      219     -5829     
+ Misses      14001      130    -13871     
  Partials        7        7               
Flag Coverage Δ
sanity ?
units 61.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thekad
thekad marked this pull request as ready for review July 22, 2025 17:56
@thekad
thekad force-pushed the feature/audit_indirect_node_counting branch from 313cbe9 to 8a6ffcd Compare July 22, 2025 22:18

@p3ck p3ck left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thekad

thekad commented Jul 29, 2025

Copy link
Copy Markdown
Collaborator Author

I am not sure what the GH action failure here is, it's apparently running python 2.7?

thekad added 2 commits August 4, 2025 22:12
Used to count resources managed in a given cloud provider, GCP in this
case. Refer to README.md for more info.
@thekad
thekad force-pushed the feature/audit_indirect_node_counting branch from 8a6ffcd to c4d0b3f Compare August 5, 2025 05:12
@thekad

thekad commented Aug 5, 2025

Copy link
Copy Markdown
Collaborator Author

With the newest release of ansible core dependencies may have been updated, I think #695 needs to be dealt with first

@felixfontein

Copy link
Copy Markdown
Contributor

There was a problem with the ansible-test GHA which is now fixed; restarting the tests should fix them. (Assuming they don't fail for other reasons ;) )

@thekad

thekad commented Aug 6, 2025

Copy link
Copy Markdown
Collaborator Author

I re-triggered all checks and they all pass now ❤️ cc @SirGitsalot

@SirGitsalot
SirGitsalot merged commit fe488d0 into ansible-collections:master Aug 14, 2025
9 of 17 checks passed
@thekad
thekad deleted the feature/audit_indirect_node_counting branch August 15, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants