add functionality to pass templates #84
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g of cisco ios Signed-off-by: jwoogee <[email protected]>
Signed-off-by: jwoogee <[email protected]>
Signed-off-by: z003gn3 <[email protected]>
Signed-off-by: z003gn3 <[email protected]>
…config_manager role. Also removed extra space from run_cli when setting name parameter for textfsm templates. Signed-off-by: z003gn3 <[email protected]>
Signed-off-by: z003gn3 <[email protected]>
Signed-off-by: z003gn3 <[email protected]>
|
Build failed.
|
|
Can someone take a look at this one? |
|
@trishnaguha Sorry to tag you, is there someone or some group I should tag when submitting a PR? I just want to make sure I'm doing it right. |
|
@jwoogee it looks like you need to add a new line to the end of the file, per the CI linter failure: |
Signed-off-by: Jonathon Woods <[email protected]>
|
Thank you, I fixed that error. |
|
Build succeeded.
|
|
@justjais can you take a look at this to review? |
|
this PR should not be merged until ansible-network/config_manager#19 is resolved and merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a PR on config_manager to add this functionality. This allows user to pass through list of templates to load. I also fixed spacing issue in run_cli task.