Skip to content

Conversation

@romartin
Copy link
Contributor

Jira Issue: https://issues.redhat.com/browse/AAP-58583

Description

Fixes:

  • Prevents from overriding the chatbot image entry-point
  • Used the python executable reference from the venv, instead of container's /usr/bin

Production deployment

  • This code change is ready for production on its own
  • This PR should be released in 2.4 (cherry-pick should be created)
  • This PR should be released in 2.5 (cherry-pick should be created)
  • This PR should be released in 2.6 (cherry-pick should be created)
  • This code change requires the following considerations before going to production:

@romartin romartin requested a review from de1987 November 17, 2025 22:01
Comment on lines -102 to +103
command:
- /bin/sh
- -c
- |
if [ -z "$PROVIDER_VECTOR_DB_ID" ]; then
if [ -f "/rag/llama_stack_vector_db/provider_vector_db_id.ind" ]; then
export PROVIDER_VECTOR_DB_ID=$(cat /rag/llama_stack_vector_db/provider_vector_db_id.ind)
echo "Loaded PROVIDER_VECTOR_DB_ID: $PROVIDER_VECTOR_DB_ID"
else
echo "ERROR: PROVIDER_VECTOR_DB_ID is not set and file /rag/llama_stack_vector_db/provider_vector_db_id.ind was not found"
exit 1
fi
fi
exec /.llama/entrypoint.sh /usr/bin/python3.12
args:
[ 'sh', '-c', 'export $(cat $LLAMA_STACK_CONFIG_DIR/distributions/ansible-chatbot/provider_rag.env | xargs) && /.llama/entrypoint.sh /app-root/.venv/bin/python3.12' ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might not be needed as it will set in the container image

Copy link
Contributor Author

@romartin romartin Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but only for downstream, but not upstream

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romartin lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants