Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use current python interpreter to run builder #305

Closed
wants to merge 3 commits into from

Conversation

cidrblock
Copy link
Collaborator

@cidrblock cidrblock commented Apr 4, 2025

Rather than rely on builder being in the PATH, use the python interpreter that spawned the ade process.

This was encountered when installing ade as a uv tool, since builder was not in the current PATH, although it was installed in the ade venv.

@cidrblock cidrblock added the bug Something isn't working label Apr 4, 2025
@cidrblock cidrblock requested a review from Copilot April 4, 2025 11:55
@cidrblock cidrblock requested a review from a team as a code owner April 4, 2025 11:55
Copilot

This comment was marked as resolved.

@cidrblock cidrblock requested a review from Copilot April 4, 2025 12:04
Copilot

This comment was marked as resolved.

@ansible ansible deleted a comment from Copilot bot Apr 4, 2025
@ansible ansible deleted a comment from Copilot bot Apr 4, 2025
@cidrblock cidrblock closed this Apr 4, 2025
@cidrblock cidrblock reopened this Apr 4, 2025
@github-project-automation github-project-automation bot moved this from Done to Review in 🧰 devtools project board Apr 4, 2025
@cidrblock cidrblock closed this Apr 4, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in 🧰 devtools project board Apr 4, 2025
@cidrblock cidrblock reopened this Apr 4, 2025
@github-project-automation github-project-automation bot moved this from Done to Review in 🧰 devtools project board Apr 4, 2025
@cidrblock cidrblock closed this Apr 4, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in 🧰 devtools project board Apr 4, 2025
@cidrblock cidrblock reopened this Apr 4, 2025
@github-project-automation github-project-automation bot moved this from Done to Review in 🧰 devtools project board Apr 4, 2025
@nitzmahone
Copy link
Member

Does it have to be the script entrypoint? If you don't mind invoking it with something like $python_in_question -m, you can just do it blindly for invocation or consult that python's distribution metadata to definitively tell that it's installed before trying to invoke it.

@cidrblock cidrblock closed this Apr 4, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in 🧰 devtools project board Apr 4, 2025
@cidrblock cidrblock reopened this Apr 4, 2025
@github-project-automation github-project-automation bot moved this from Done to Review in 🧰 devtools project board Apr 4, 2025
@cidrblock
Copy link
Collaborator Author

Does it have to be the script entrypoint? If you don't mind invoking it with something like $python_in_question -m, you can just do it blindly for invocation or consult that python's distribution metadata to definitively tell that it's installed before trying to invoke it.

Brilliant. I hadn't even considered -m.... assuming this would work, I can probable skip the subproccess all together and runpy it :) Let me see how it looks

@cidrblock cidrblock changed the title Find builder adjacent to python interpreter Use current python interpreter to run builder Apr 4, 2025
@cidrblock
Copy link
Collaborator Author

Closed in favor of #306

@cidrblock cidrblock closed this Apr 4, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in 🧰 devtools project board Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants