Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure zsh and oh-my-zsh are installed on both images #530

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Jan 26, 2025

This brings the two container images closer and fixes two problems with zsh on devspaces container:

  • login with zsh would block due to interactive first time install
  • zsh prompt was broken

Further changes should also address the 10 currently ignored tests on devspaces image.

@ssbarnea ssbarnea requested a review from a team as a code owner January 26, 2025 21:56
@github-actions github-actions bot added bug Something isn't working minor labels Jan 26, 2025
@ssbarnea ssbarnea changed the title Avoid zsh hang due to first run wizard Ensure zsh and oh-my-zsh are installed on both images Jan 26, 2025
@ssbarnea ssbarnea removed the bug Something isn't working label Jan 26, 2025
@abhikdps abhikdps merged commit e97e50b into main Jan 27, 2025
31 of 32 checks passed
@abhikdps abhikdps deleted the fix/deps branch January 27, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants