Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start running synchronous tests, separate from asyncio tests #129

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

AlanCoding
Copy link
Member

Fixes #9

I described in more recent issues - the intent would be to ultimately replace all the existing async tests.

This has a nasty warning:

/home/alancoding/venvs/awx/lib64/python3.12/site-packages/psycopg/_connection_base.py:146: ResourceWarning: connection <psycopg.Connection [IDLE] (host=localhost port=55777 user=dispatch database=dispatch_db) at 0x7efbef973710> was deleted while still open. Please use 'with' or '.close()' to close the connection

I expect that will be resolved with connection closing @art-tapin did in #121. Maybe.

Right now this test is slow, but the idea is that we'll start to reuse the fixture between tests and then it will start to go faster. The idea is also to reuse this in AWX and eda-server.

@AlanCoding
Copy link
Member Author

Tests are timeouts.

I suspect, though I do not know, this might be because I didn't call process.close(). It is also the first time we ran both subprocess and asyncio tests in the same run, so it may also not be surprising that we hit new hangs in this situation. But it's hard to clean up processes.

@AlanCoding AlanCoding changed the title Start on synchronous testing [WIP] Start on synchronous testing Mar 18, 2025
Close queues, hopefully fixed race condition
@AlanCoding AlanCoding changed the title [WIP] Start on synchronous testing Start running synchronous tests, separate from asyncio tests Mar 21, 2025
@AlanCoding AlanCoding marked this pull request as ready for review March 21, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dispatcher/testing/ utilities to help testing
1 participant