Move Activation Copy to Separate Module-AAP-42215 #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzwei
requested changes
Mar 25, 2025
bzwei
reviewed
Mar 26, 2025
After we introduced the usage of the proxy profile in ansible#414, we didn't include the same profile in the `down` command. This leaves behind the squid service as well as its container, when they should all be removed when `docker compose down` is issued.
B-Whitt
force-pushed
the
activation-copy-mod-AAP-42215
branch
from
b2f7927 to
c082010
Compare
bzwei
previously approved these changes
Mar 27, 2025
zkayyali812
reviewed
Mar 27, 2025
zkayyali812
previously approved these changes
Mar 27, 2025
kaiokmo
requested changes
Mar 28, 2025
kaiokmo
requested changes
Mar 28, 2025
bzwei
approved these changes
Mar 28, 2025
|
@B-Whitt are we planning to remove the existing copy functionality from the rulebook_activation module in a different PR, and also change the integration tests accordingly? |
@kaiokmo |
zkayyali812
approved these changes
Mar 28, 2025
kaiokmo
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new module is created for the copy action to copy the activation.
It has been discussed and decided that we shall move the existing copy action from the activation module to a separate module. The copy action shall take only one parameter which is the name of the copied activation. The resulting activation should be in disabled state. [https://issues.redhat.com/browse/AAP-42215]