Add a feature tree #821
Open
Add a feature tree #821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greschd
commented
Apr 17, 2025
| 'P1__ModelingPly.1' | ||
| Analysis Plies | ||
| 'P1L1__ModelingPly.1' | ||
| └── 'ACP Model' |
There was a problem hiding this comment.
This is a change in behavior of the existing print_model method (added lines to the output).
We could avoid it by setting show_lines to False by default. However:
- the change is relatively minor + easily reverted by passing
show_lines=False - (to my eye) the version with lines looks easier to parse
What's your take on this?
There was a problem hiding this comment.
Fine with me. The lines help to read the data.
greschd
force-pushed
the
feat/feature_tree
branch
2 times, most recently
from
6aac8e5 to
0ad99e2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #821 +/- ##
==========================================
+ Coverage 94.91% 94.92% +0.01%
==========================================
Files 109 110 +1
Lines 5737 5771 +34
Branches 328 333 +5
==========================================
+ Hits 5445 5478 +33
- Misses 291 292 +1
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
greschd
force-pushed
the
feat/feature_tree
branch
2 times, most recently
from
e4284bc to
b5e0642
Compare
|
The |
greschd
commented
Apr 17, 2025
| @@ -1,11 +0,0 @@ | |||
| Example helpers | |||
greschd
force-pushed
the
feat/feature_tree
branch
from
b5e0642 to
1897f3f
Compare
Add helper functions to either print a tree of ACP objects, or print it. In the documentation, show the tree structure, and explain how it affects the access and creation of objects. To implement the feature tree, record metadata when creating mapping properties (value type, and read-only status), and use a separate _exposed_grpc_property subclass to indicate it is a mapping.
greschd
force-pushed
the
feat/feature_tree
branch
from
1897f3f to
023b59b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add helper functions to either print a tree of ACP objects, or
print it. In the documentation, show the tree structure, and
explain how it affects the access and creation of objects.
To implement the feature tree, record metadata when creating
mapping properties (value type, and read-only status), and use
a separate _exposed_grpc_property subclass to indicate it is
a mapping.
Other changes:
connecting the nodes
25R2 hardening item 11.