Skip to content

FIX: layer error in via array #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

FIX: layer error in via array #415

wants to merge 6 commits into from

Conversation

@gkorompi
Copy link
Collaborator

@gkorompi gkorompi commented Aug 30, 2025 •
edited
Loading

Description

same PR as #413 but with correct file path

Issue linked

Checklist

Please complete the following checklist before submitting your pull request:

  • I have followed the example template and guide lines to add/update an example.
  • I have tested the example locally and verified that it is working with the latest version of AEDT.
  • I have verified that these changes to the best of my knowledge do not introduce any security vulnerabilities.

hui-zhou-a
hui-zhou-a requested changes Aug 31, 2025
View reviewed changes
Copy link
Collaborator

@hui-zhou-a hui-zhou-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ground were correctly placed on layer Top. This is a typical CPW structure.

@Samuelopez-ansys Samuelopez-ansys marked this pull request as draft September 1, 2025 12:20
@hui-zhou-a hui-zhou-a closed this Sep 2, 2025
@gkorompi gkorompi reopened this Sep 3, 2025
@gkorompi
Copy link
Collaborator Author

gkorompi commented Sep 3, 2025 •
edited
Loading

laced on layer Top. This is a typical CPW structure.

Ah right. Nevertheless, the vias shouldn't hang like this. I added an extra ground plane

@gkorompi
Copy link
Collaborator Author

gkorompi commented Sep 3, 2025

@svandenb-dev @hui-zhou-a refactored the example. Please review

@gkorompi gkorompi requested a review from hui-zhou-a September 3, 2025 12:21
svandenb-dev
svandenb-dev previously approved these changes Sep 22, 2025
View reviewed changes
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev marked this pull request as ready for review September 22, 2025 11:35
@gkorompi
Copy link
Collaborator Author

LGTM

@Samuelopez-ansys @SMoraisAnsys can you please approve? thanks

@hui-zhou-a
Copy link
Collaborator

@gkorompi could you update the branch, and also correct the below issue.
image

hui-zhou-a
hui-zhou-a requested changes Sep 30, 2025
View reviewed changes
Copy link
Collaborator

@hui-zhou-a hui-zhou-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkorompi can you fix this?
#415 (comment)

SMoraisAnsys
SMoraisAnsys reviewed Sep 30, 2025
View reviewed changes
@Samuelopez-ansys
Copy link
Member

Hi @gkorompi @hui-zhou-a, what is the status of this?

@hui-zhou-a hui-zhou-a marked this pull request as draft October 2, 2025 10:58
@hui-zhou-a
Copy link
Collaborator

@gkorompi I change this PR to draft. Could you prioritize this PR? It is not ideal to have long standing PR.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 2, 2025
@hui-zhou-a hui-zhou-a marked this pull request as ready for review October 2, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SMoraisAnsys SMoraisAnsys SMoraisAnsys left review comments

@hui-zhou-a hui-zhou-a hui-zhou-a approved these changes

@svandenb-dev svandenb-dev svandenb-dev left review comments

@maxcapodi78 maxcapodi78 Awaiting requested review from maxcapodi78 maxcapodi78 is a code owner

@Samuelopez-ansys Samuelopez-ansys Awaiting requested review from Samuelopez-ansys Samuelopez-ansys is a code owner

@gmalinve gmalinve Awaiting requested review from gmalinve gmalinve is a code owner

@Devin-Crawford Devin-Crawford Awaiting requested review from Devin-Crawford Devin-Crawford is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gkorompi @hui-zhou-a @Samuelopez-ansys @svandenb-dev @SMoraisAnsys