Skip to content

Commit

Permalink
added suggestion
Browse files Browse the repository at this point in the history
  • Loading branch information
maxcapodi78 committed Feb 6, 2025
1 parent 8a6ab01 commit 92973fa
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 15 deletions.
2 changes: 1 addition & 1 deletion src/ansys/aedt/core/desktop.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def launch_desktop_on_port():

timeout = settings.desktop_launch_timeout
k = 0
while not _is_port_occupied(port):
while not port in grpc_active_sessions(non_graphical=non_graphical):
if k > timeout: # pragma: no cover
active_s = active_sessions(student_version=student_version)
for pid in active_s:
Expand Down
29 changes: 15 additions & 14 deletions src/ansys/aedt/core/modules/setup_templates.py
Original file line number Diff line number Diff line change
Expand Up @@ -1959,20 +1959,21 @@ def get_setup_templates():
from ansys.aedt.core.generic.general_methods import settings

template = SetupKeys.SetupTemplates
if settings.aedt_version is not None and settings.aedt_version >= "2025.1":
template = SetupKeys._add_to_template(SetupKeys.SetupTemplates, SetupKeys.SetupTemplates_231)
template = SetupKeys._add_to_template(template, SetupKeys.SetupTemplates_232)
template = SetupKeys._add_to_template(template, SetupKeys.SetupTemplates_241)
template = SetupKeys._add_to_template(template, SetupKeys.SetupTemplates_251)
elif settings.aedt_version is not None and settings.aedt_version >= "2024.1":
template = SetupKeys._add_to_template(SetupKeys.SetupTemplates, SetupKeys.SetupTemplates_231)
template = SetupKeys._add_to_template(template, SetupKeys.SetupTemplates_232)
template = SetupKeys._add_to_template(template, SetupKeys.SetupTemplates_241)
elif settings.aedt_version is not None and settings.aedt_version >= "2023.2":
template = SetupKeys._add_to_template(SetupKeys.SetupTemplates, SetupKeys.SetupTemplates_231)
template = SetupKeys._add_to_template(template, SetupKeys.SetupTemplates_232)
elif settings.aedt_version is not None and settings.aedt_version >= "2023.1":
template = SetupKeys._add_to_template(SetupKeys.SetupTemplates, SetupKeys.SetupTemplates_231)
if settings.aedt_version is not None:
if settings.aedt_version >= "2025.1":
template = SetupKeys._add_to_template(SetupKeys.SetupTemplates, SetupKeys.SetupTemplates_231)
template = SetupKeys._add_to_template(template, SetupKeys.SetupTemplates_232)
template = SetupKeys._add_to_template(template, SetupKeys.SetupTemplates_241)
template = SetupKeys._add_to_template(template, SetupKeys.SetupTemplates_251)

Check warning on line 1967 in src/ansys/aedt/core/modules/setup_templates.py

View check run for this annotation

Codecov / codecov/patch

src/ansys/aedt/core/modules/setup_templates.py#L1964-L1967

Added lines #L1964 - L1967 were not covered by tests
elif settings.aedt_version >= "2024.1":
template = SetupKeys._add_to_template(SetupKeys.SetupTemplates, SetupKeys.SetupTemplates_231)
template = SetupKeys._add_to_template(template, SetupKeys.SetupTemplates_232)
template = SetupKeys._add_to_template(template, SetupKeys.SetupTemplates_241)
elif settings.aedt_version >= "2023.2":
template = SetupKeys._add_to_template(SetupKeys.SetupTemplates, SetupKeys.SetupTemplates_231)
template = SetupKeys._add_to_template(template, SetupKeys.SetupTemplates_232)
elif settings.aedt_version >= "2023.1":
template = SetupKeys._add_to_template(SetupKeys.SetupTemplates, SetupKeys.SetupTemplates_231)

Check warning on line 1976 in src/ansys/aedt/core/modules/setup_templates.py

View check run for this annotation

Codecov / codecov/patch

src/ansys/aedt/core/modules/setup_templates.py#L1972-L1976

Added lines #L1972 - L1976 were not covered by tests
return template

def get_default_icepak_template(self, default_type):
Expand Down

0 comments on commit 92973fa

Please sign in to comment.