FEAT: Added support for 25R1 EMI Receiver component RBW and RBW Factor feat…

[cmesibov]

Description

This PR adds support for 25R1 EMI Receiver component RBW and RBW Factor settings.

Issue linked

Issue #5585

Checklist

• I have tested my changes locally.
• I have added necessary documentation or updated existing documentation.
• I have followed the coding style guidelines of this project.
• I have added appropriate tests (unit, integration, system).
• I have reviewed my changes before submitting this pull request.
• I have linked the issue or issues that are solved by the PR if any.
• I have agreed with the Contributor License Agreement (CLA).

[ansys-reviewer-bot]

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.24%. Comparing base (9dc739d) to head (bfa67c4).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5640      +/-   ##
==========================================
- Coverage   85.26%   85.24%   -0.02%     
==========================================
  Files         155      155              
  Lines       60795    60809      +14     
==========================================
+ Hits        51834    51838       +4     
- Misses       8961     8971      +10     

[SMoraisAnsys]

Hi @cmesibov thanks for the contribution. There are a few things that should be modified in your contribution. First, could you add a description to your PR ?

Now more dev oriented:

• Since you added attributes rbw and rbw_factor with default values, it doesn't make sense to create the property getters (or the behavior might not be the one you expect).
• The previous default value for RBW was 9000Hz, could you leave that same default value for backward compatibility ?
• From the previous behavior, I imagine that RBW must be a string so I'm not sure it's needed to cast it into a string in emission
• Can you add some tests to ensure that things work as expected ?

Finally, you told me that you would test your changes on previous AEDT versions. Did you do that ?

[cmesibov]

@SMoraisAnsys , Thanks for the review. The RBW and RBW Factor settings are set by index, not by value. Therefore the text setting of "900MHz" was in error to begin with. The new init defaults of zero should be the default setting. I have tested the changes on my own project for 24R2 and 25R1. Would adding RBW and RWB Factor settings to test_76_emi_receiver be adequate?

[SMoraisAnsys]

test_76_emi_receiver

I don't know about that. If you have a simple reproducer that would be great. Otherwise, modifying an existing one is also a solution. From the PR title, some changes (most likely the RBW Factor) seem to be related to a specific version - I mean that it requires a minimum version. If that's the case, would you consider having a look at #5631 ?

[Devin-Crawford]

@cmesibov : I updated the title - otherwise it will fail in the checks.

[Devin-Crawford]

@cmesibov : It looks like this change fixes an error, but there was not defect submitted. For future reference it will be easier to understand what you did if you submit an issue describing what's wrong and then refer to that issue when you do the PR. Otherwise, this looks good.

[SMoraisAnsys]

@cmesibov : It looks like this change fixes an error, but there was not defect submitted. For future reference it will be easier to understand what you did if you submit an issue describing what's wrong and then refer to that issue when you do the PR. Otherwise, this looks good.

From my understanding, it seems that RBW was not something we could use before and setting whatever value did not cause an issue.
Here the changes are introducing the ability to work with RBW and RBW Factor.
@cmesibov Can you add tests as previously asked ?
Also, is the change on RBW Factor backward compatible ? Should we add a decorator to state that one shouldn't update the RBW value and RBW factor value with previous version of AEDT (see the changes introduced in #5631) ?

[cmesibov]

@Devin-Crawford HI Devin, I open a pyaedt git hub issue #5585 for the EMI receiver update for 25R1.

[cmesibov]

@SMoraisAnsys I will be pushing the update for the added tests today. Sorry for the delay.

[cmesibov]

"Also, is the change on RBW Factor backward compatible ? Should we add a decorator to state that one shouldn't update the RBW value and RBW factor value with previous version of AEDT (see the changes introduced in #5631) ?"

Testing has shown that the 25R1 targeted feature doesn't cause a desktop error in 24R1 and 24R2. But having the decorator sounds like a good idea.

[cmesibov]

@SMoraisAnsys I have pushed updates with RBW and RBW factor values added to test_76_emi_receiver(). I think this will satisfy your requested change.

[SMoraisAnsys]

I'll look at the changes when the test are passing

[cmesibov]

@SMoraisAnsys looks like the tests were successful. I invited @maxcapodi78 Massimo to review. I think we don't need to detect 25R1 for the new feature because 24R1 and 24R2 ignore the new 25R1 feature properties. Perhaps Massimo can weigh in, as he is familiar with the physics. Is there a decorator already available that can be applied?