-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Add distributed filters substrate #5646
Conversation
…sys/pyaedt into FEAT__Add_distributed_filters # Conflicts: # src/ansys/aedt/core/filtersolutions.py
For more information, see https://pre-commit.ci
…sys/pyaedt into FEAT__Add_distributed_filters
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5646 +/- ##
==========================================
+ Coverage 85.20% 85.21% +0.01%
==========================================
Files 156 156
Lines 61112 61112
==========================================
+ Hits 52068 52078 +10
+ Misses 9044 9034 -10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ramin4667, thanks for the contribution !
Are these changes only available starting with AEDT 2025.2 ? If that's the case, would you consider having a look at #5631 where there is a decorator you might want to leverage (if it gets merged)
@SMoraisAnsys Thanks for informing me. I have added a version check for older versions that are not supported. |
src/ansys/aedt/core/filtersolutions_core/distributed_topology.py
Outdated
Show resolved
Hide resolved
…hub.com/ansys/pyaedt into FEAT__Add_distributed_filters_substrate
…_filters_substrate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ramin4667 It's looking really good. Great tests and I like the way this supports string and enum for properties with flexible input. I had just a few questions.
Description
This PR adds attributes of the substrate page of distributed filters to the FilterSolutions API.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist