Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Add distributed filters substrate #5646

Merged
merged 26 commits into from
Feb 5, 2025

Conversation

ramin4667
Copy link
Contributor

Description

This PR adds attributes of the substrate page of distributed filters to the FilterSolutions API.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • [x ] I have added necessary documentation or updated existing documentation.
  • [x ] I have followed the coding style guidelines of this project.
  • [x ] I have added appropriate tests (unit, integration, system).
  • [x ] I have reviewed my changes before submitting this pull request.
  • [x ] I have linked the issue or issues that are solved by the PR if any.
  • [x ] I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added testing Anything related to testing enhancement New features or code improvements labels Jan 10, 2025
@ramin4667 ramin4667 changed the title Feat: Add distributed filters substrate FEAT: Add distributed filters substrate Jan 10, 2025
@ramin4667 ramin4667 requested a review from myoung301 January 10, 2025 19:31
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.21%. Comparing base (b191b67) to head (465f101).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5646      +/-   ##
==========================================
+ Coverage   85.20%   85.21%   +0.01%     
==========================================
  Files         156      156              
  Lines       61112    61112              
==========================================
+ Hits        52068    52078      +10     
+ Misses       9044     9034      -10     

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ramin4667, thanks for the contribution !
Are these changes only available starting with AEDT 2025.2 ? If that's the case, would you consider having a look at #5631 where there is a decorator you might want to leverage (if it gets merged)

@ramin4667
Copy link
Contributor Author

@SMoraisAnsys Thanks for informing me. I have added a version check for older versions that are not supported.

Copy link
Contributor

@myoung301 myoung301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramin4667 It's looking really good. Great tests and I like the way this supports string and enum for properties with flexible input. I had just a few questions.

@myoung301 myoung301 enabled auto-merge (squash) February 4, 2025 16:15
@myoung301 myoung301 merged commit 8184a17 into main Feb 5, 2025
43 checks passed
@myoung301 myoung301 deleted the FEAT__Add_distributed_filters_substrate branch February 5, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants