-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Identify coupling 5649 #5659
Conversation
…touchstone_parser.py
…touchstone_parser.py
…touchstone_parser.py
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
For more information, see https://pre-commit.ci
…ntify_coupling_5649
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5659 +/- ##
=======================================
Coverage 85.20% 85.21%
=======================================
Files 156 156
Lines 61071 61107 +36
=======================================
+ Hits 52035 52070 +35
- Misses 9036 9037 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amichel0205 please use a valid s-parameter for testing.
…ntify_coupling_5649
For more information, see https://pre-commit.ci
For more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some refactoring proposition.
src/ansys/aedt/core/visualization/advanced/touchstone_parser.py
Outdated
Show resolved
Hide resolved
src/ansys/aedt/core/visualization/advanced/touchstone_parser.py
Outdated
Show resolved
Hide resolved
src/ansys/aedt/core/visualization/advanced/touchstone_parser.py
Outdated
Show resolved
Hide resolved
src/ansys/aedt/core/visualization/advanced/touchstone_parser.py
Outdated
Show resolved
Hide resolved
src/ansys/aedt/core/visualization/advanced/touchstone_parser.py
Outdated
Show resolved
Hide resolved
src/ansys/aedt/core/visualization/advanced/touchstone_parser.py
Outdated
Show resolved
Hide resolved
src/ansys/aedt/core/visualization/advanced/touchstone_parser.py
Outdated
Show resolved
Hide resolved
src/ansys/aedt/core/visualization/advanced/touchstone_parser.py
Outdated
Show resolved
Hide resolved
src/ansys/aedt/core/visualization/advanced/touchstone_parser.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/ansys/aedt/core/visualization/advanced/touchstone_parser.py
Outdated
Show resolved
Hide resolved
src/ansys/aedt/core/visualization/advanced/touchstone_parser.py
Outdated
Show resolved
Hide resolved
src/ansys/aedt/core/visualization/advanced/touchstone_parser.py
Outdated
Show resolved
Hide resolved
src/ansys/aedt/core/visualization/advanced/touchstone_parser.py
Outdated
Show resolved
Hide resolved
src/ansys/aedt/core/visualization/advanced/touchstone_parser.py
Outdated
Show resolved
Hide resolved
src/ansys/aedt/core/visualization/advanced/touchstone_parser.py
Outdated
Show resolved
Hide resolved
Requested changes implemented
Description
This feature is useful for large RF board where user want to identified unwanted coupling.
User will specify:
Sparameter file full path
Log file full path
low_loss and high_loss range
Frequency start at which to start looking for the coupling(such we can skip low frequency where DC block exist)
Sample frequency(to speed up process chack coupling at each sample)
Issue linked
Close #5649
Checklist