Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHORE: SetupMaxwell refactoring to save fields and new SweepMaxwell for EC solvers #5670

Merged
merged 18 commits into from
Feb 6, 2025

Conversation

gmalinve
Copy link
Contributor

Description

**In this PR I want to:

  • Improve the SetupMaxwell class in order to be able to save fields for all solvers.
  • Add a new class in solve_sweep to handle EC freq. sweeps.
  • Add/improve the already exisiting method to add frequency sweeps for EC in order to return the sweep object.**

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 85.21%. Comparing base (2532517) to head (6c44dbe).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5670      +/-   ##
==========================================
+ Coverage   83.73%   85.21%   +1.48%     
==========================================
  Files         156      156              
  Lines       61063    61171     +108     
==========================================
+ Hits        51131    52129     +998     
+ Misses       9932     9042     -890     

@gmalinve gmalinve marked this pull request as ready for review February 4, 2025 10:18
Copy link
Contributor

@jvela018 jvela018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmalinve ,

I made some general comments that I'd like to iterate over.

src/ansys/aedt/core/modules/solve_setup.py Show resolved Hide resolved
src/ansys/aedt/core/modules/setup_templates.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/modules/solve_setup.py Show resolved Hide resolved
src/ansys/aedt/core/modules/solve_setup.py Show resolved Hide resolved
src/ansys/aedt/core/modules/solve_setup.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/modules/solve_sweeps.py Show resolved Hide resolved
Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxcapodi78 maxcapodi78 merged commit f87d9a1 into main Feb 6, 2025
43 checks passed
@maxcapodi78 maxcapodi78 deleted the chore/maxwell_setup_refactor branch February 6, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SetupMaxwell refactoring and implement SweepMaxwellEC
3 participants