Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Enable field plotting with discrete sweep #5683

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

Devin-Crawford
Copy link
Contributor

  • Allow sweep.name as a setup.
    • pass variations as optional keywords
  • "SaveRadFields" default is False in setup_templates.py
  • pass props to SweepHFSS()

Description

Enable plotting of solution and far-field data from a single frequency point
in a discrete sweep.

Issue linked

#5682
#5630

Checklist

  • [x ] I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • [x ] I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

- Allow sweep.name as a setup.
  - pass variations as optional keywords
- "SaveRadFields" default is False in setup_templates.py
- pass props to SweepHFSS()
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 2.17391% with 45 lines in your changes missing coverage. Please review.

Project coverage is 18.07%. Comparing base (f4b3c44) to head (ea88df1).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5683       +/-   ##
===========================================
- Coverage   81.38%   18.07%   -63.32%     
===========================================
  Files         155      155               
  Lines       60819    60836       +17     
===========================================
- Hits        49499    10996    -38503     
- Misses      11320    49840    +38520     

Devin-Crawford and others added 6 commits January 23, 2025 04:58
- Fix loop syntax.
- Add correct logger syntax.
- Report type for far_field should be "Radiation Pattern"
- Fix error in FarField class when assigning variations.
…license-issues' into fix_HFSS_linear_step_sweep
@github-actions github-actions bot added the maintenance Package and maintenance related label Jan 26, 2025
Devin-Crawford and others added 5 commits January 26, 2025 17:56
- Add test project file Potter_Horn_242.aedtz
- Update unit test to check field plotting for discrete sweep.
- Allow sweep name to be passed to `create_report_from_configuration()`
- Revert setup_templates.py
- Correct docstring error in hfss.py
- update unit test for discrete frequency sweep in HFSS.
@Devin-Crawford Devin-Crawford marked this pull request as ready for review January 30, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants