Skip to content

REFACTOR: 12_post_processing refactoring #6051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 38 commits into from

Conversation

nunesanderson
Copy link
Contributor

@nunesanderson nunesanderson commented Apr 15, 2025

Description

Post processing test refactor

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@nunesanderson nunesanderson requested a review from gmalinve April 15, 2025 14:10
@gmalinve gmalinve linked an issue Apr 16, 2025 that may be closed by this pull request
@gmalinve gmalinve changed the title 12_post_processing refactoring REFACTOR: 12_post_processing refactoring Apr 16, 2025
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.49%. Comparing base (d48283a) to head (a4b176f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6051      +/-   ##
==========================================
- Coverage   85.15%   82.49%   -2.67%     
==========================================
  Files         167      167              
  Lines       63153    63157       +4     
==========================================
- Hits        53781    52101    -1680     
- Misses       9372    11056    +1684     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nunesanderson nunesanderson marked this pull request as ready for review April 16, 2025 12:34
Copy link
Contributor

@gmalinve gmalinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nunesanderson thanks for taking care of this! :)
Here some suggestions:

  • I'd improve the test method names (test_manipulate_report_A, B, C etc.)
  • All tests don't have a single purpose, they assert multiple methods.
  • There are some methods that are asserted more than once in different tests (just as an example you can look at export_config and create_report_from_configuration just to mention a couple). We could check if there are repetitions without decreasing codecov.
  • There are also some tests (test_parse_vector) where we test protected methods (is it really needed?). We can check.
  • There are some tests, just as an example test_markers that creates multiple field plots to test markers. Maybe we could avoid some cases and open an aedtz where the field plot is already created.

Comment on lines 155 to 157
# @pytest.fixture(autouse=True)
# def init(self, local_scratch):
# self.local_scratch = local_scratch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nunesanderson remove.

@nunesanderson nunesanderson force-pushed the refactor/12_post_processing_fixed_pr branch from 0a3bcbc to 997f966 Compare April 28, 2025 10:06
jvela018 and others added 16 commits April 30, 2025 10:26
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Samuelopez-ansys <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Samuel Lopez <[email protected]>
…6041)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pyansys-ci-bot <[email protected]>
…0,<6.2 (#6042)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Maxime Rey <[email protected]>
Co-authored-by: Samuel Lopez <[email protected]>
maxcapodi78 and others added 16 commits April 30, 2025 10:26
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Samuel Lopez <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Samuel Lopez <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pyansys-ci-bot <[email protected]>
…6082)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@nunesanderson nunesanderson force-pushed the refactor/12_post_processing_fixed_pr branch from 997f966 to 1033908 Compare April 30, 2025 08:27
@github-actions github-actions bot added maintenance Package and maintenance related documentation Improvements or additions to documentation labels Apr 30, 2025
@nunesanderson nunesanderson deleted the refactor/12_post_processing_fixed_pr branch April 30, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

12_post_processing file refactoring
8 participants