-
Notifications
You must be signed in to change notification settings - Fork 150
REFACTOR: 12_post_processing refactoring #6051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6051 +/- ##
==========================================
- Coverage 85.15% 82.49% -2.67%
==========================================
Files 167 167
Lines 63153 63157 +4
==========================================
- Hits 53781 52101 -1680
- Misses 9372 11056 +1684 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nunesanderson thanks for taking care of this! :)
Here some suggestions:
- I'd improve the test method names (test_manipulate_report_A, B, C etc.)
- All tests don't have a single purpose, they assert multiple methods.
- There are some methods that are asserted more than once in different tests (just as an example you can look at export_config and create_report_from_configuration just to mention a couple). We could check if there are repetitions without decreasing codecov.
- There are also some tests (test_parse_vector) where we test protected methods (is it really needed?). We can check.
- There are some tests, just as an example test_markers that creates multiple field plots to test markers. Maybe we could avoid some cases and open an aedtz where the field plot is already created.
# @pytest.fixture(autouse=True) | ||
# def init(self, local_scratch): | ||
# self.local_scratch = local_scratch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nunesanderson remove.
0a3bcbc
to
997f966
Compare
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]> Co-authored-by: Maxime Rey <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]> Co-authored-by: Sébastien Morais <[email protected]> Co-authored-by: Samuelopez-ansys <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]> Co-authored-by: Samuel Lopez <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]>
…6041) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <[email protected]>
…0,<6.2 (#6042) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <[email protected]> Co-authored-by: Sébastien Morais <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <[email protected]> Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]> Co-authored-by: Maxime Rey <[email protected]> Co-authored-by: Samuel Lopez <[email protected]>
) Co-authored-by: pyansys-ci-bot <[email protected]> Co-authored-by: Samuelopez-ansys <[email protected]>
Co-authored-by: Samuel Lopez <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]> Co-authored-by: Samuel Lopez <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]> Co-authored-by: Samuel Lopez <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]> Co-authored-by: pyansys-ci-bot <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]>
…6082) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <[email protected]> Co-authored-by: Sébastien Morais <[email protected]>
…6088) Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]> Co-authored-by: Sébastien Morais <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
997f966
to
1033908
Compare
Description
Post processing test refactor
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist