-
Notifications
You must be signed in to change notification settings - Fork 202
REFACTOR: Conftest refactoring and local_config cleaning #6727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACTOR: Conftest refactoring and local_config cleaning #6727
Conversation
…ithub.com/ansys/pyaedt into refactor/outdated-local-config-parameters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6727 +/- ##
=======================================
Coverage 83.31% 83.31%
=======================================
Files 246 246
Lines 77436 77436
=======================================
Hits 64518 64518
Misses 12918 12918 🚀 New features to boost your workflow:
|
…tor/outdated-local-config-parameters' of https://github.com/ansys/pyaedt into refactor/outdated-local-config-parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @eblanco-ansys. It's a good idea to leverage PYAEDT_LOCAL_SETTINGS_PATH for testing since that's one of the way we promote to setup PyAEDT. I also like the fact of having a single location to change every test behavior. However, I think this changes have been discussed in the past and there was a request to have conftest files for every test folder in order to finely configure just a subset of tests. Maybe things have evolved and the team would agree to a single location for setting everything (I'm voting for it) but it needs to be discussed too :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left a minor comment where only 1 fixture was not modified and the rest got refactored
Description
tests/conftest.pyMissing
local_config.jsonparametersIssue linked
#6474
Checklist