Skip to content

Conversation

@Devin-Crawford
Copy link
Contributor

@Devin-Crawford Devin-Crawford commented Oct 15, 2025

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

- Refactor AvailableMethods class
  - add nominal_variation() method
  - deprecate get_independent_nominal_values()
  - update Analysis._export_touchstone() (fix #6744)
@Devin-Crawford Devin-Crawford changed the title Update analysis.py FIX: 6744-Update analysis.py Oct 15, 2025
@github-actions github-actions bot added the bug Something isn't working label Oct 15, 2025
@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.31%. Comparing base (25341ee) to head (53e5640).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6770   +/-   ##
=======================================
  Coverage   83.31%   83.31%           
=======================================
  Files         246      246           
  Lines       77423    77429    +6     
=======================================
+ Hits        64507    64512    +5     
- Misses      12916    12917    +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gmalinve gmalinve removed their assignment Oct 19, 2025
@Devin-Crawford Devin-Crawford marked this pull request as ready for review October 23, 2025 11:52
@Devin-Crawford Devin-Crawford requested a review from a team as a code owner October 23, 2025 11:52
@Devin-Crawford Devin-Crawford enabled auto-merge (squash) October 23, 2025 11:53
@Devin-Crawford Devin-Crawford marked this pull request as draft October 24, 2025 12:59
auto-merge was automatically disabled October 24, 2025 12:59

Pull request was converted to draft

@github-actions github-actions bot added the testing Anything related to testing label Oct 24, 2025
@Devin-Crawford Devin-Crawford marked this pull request as ready for review October 25, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem in exporting touchstone file with PyAEDT - Optimetrics - HFSS

3 participants