Skip to content

Conversation

@ramin4667
Copy link
Contributor

@ramin4667 ramin4667 commented Oct 16, 2025

Description

**This PR fixes the error due to non-digit circuit element IDs. **

Issue linked

**The post-processing call for the simulated circuit of this example https://examples.aedt.docs.pyansys.com/version/dev/examples/high_frequency/radiofrequency_mmwave/lumped_element.html raises an error. **

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ramin4667 ramin4667 requested a review from a team as a code owner October 16, 2025 14:56
@ramin4667 ramin4667 requested a review from myoung301 October 16, 2025 14:57
@ramin4667 ramin4667 changed the title Bug located in primitives circuit module [FIX] Bug located in primitives circuit module Oct 16, 2025
@ramin4667 ramin4667 changed the title [FIX] Bug located in primitives circuit module FIX: Bug located in primitives circuit module Oct 16, 2025
@eblanco-ansys eblanco-ansys marked this pull request as draft October 16, 2025 15:01
@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.47%. Comparing base (f5a2b8c) to head (94b1858).
⚠️ Report is 1 commits behind head on main.

❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6775       +/-   ##
===========================================
- Coverage   79.15%   51.47%   -27.69%     
===========================================
  Files         246      246               
  Lines       77423    77423               
===========================================
- Hits        61284    39853    -21431     
- Misses      16139    37570    +21431     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eblanco-ansys eblanco-ansys marked this pull request as ready for review October 16, 2025 18:18
@gmalinve
Copy link
Contributor

Hi @ramin4667 ,

Do you have an issue linked to this PR? if yes please link it.

Thanks,

KR,

Giulia

@gmalinve gmalinve linked an issue Oct 19, 2025 that may be closed by this pull request
2 tasks
@ramin4667
Copy link
Contributor Author

Hi @ramin4667 ,

Do you have an issue linked to this PR? if yes please link it.

Thanks,

KR,

Giulia

Hi @gmalinve, The PR is updated with a link to an issue.

@gmalinve
Copy link
Contributor

Hi @ramin4667, yes. I linked it before.

Copy link
Contributor

@myoung301 myoung301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the other occurrences of setting id have been updated and the tests are passing still.

Copy link
Contributor

@myoung301 myoung301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramin4667 There is at least one change needed for the tests. I saw a failure caused by the test looking for an int where the type is now a string. Please review the failing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug located in primitives_circuit module

5 participants