Skip to content

Conversation

@SMoraisAnsys
Copy link
Collaborator

Description

Previously the method create_current_source_from_objects was failing when one passed a Object3d as source or target because the checking of the existence of this object was only performed for int and str. However, the method should be working with input of type Object3d as described in the docstring (and because it makes sense tbh).

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@SMoraisAnsys SMoraisAnsys requested a review from a team as a code owner October 23, 2025 13:49
@SMoraisAnsys SMoraisAnsys self-assigned this Oct 23, 2025
@github-actions github-actions bot added the bug Something isn't working label Oct 23, 2025
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.32%. Comparing base (f5a2b8c) to head (2cb9fcd).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6804      +/-   ##
==========================================
+ Coverage   79.15%   83.32%   +4.16%     
==========================================
  Files         246      246              
  Lines       77423    77426       +3     
==========================================
+ Hits        61284    64513    +3229     
+ Misses      16139    12913    -3226     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants