Conversation
Add a couple convenience functions to EmitNode to get the node's fullname and it's parent node's name.
SMoraisAnsys
left a comment
There was a problem hiding this comment.
LGTM, I left a minor comment.
Adds min version decorator to all node methods
|
@Samuelopez-ansys @SMoraisAnsys Anything else for this PR? |
There is a huge conflict it seems |
|
@jsalant22 I have fixed all conflict, the root cuase was that you added -> None to all setters, and the setter should not return anything. @SMoraisAnsys Do you agree adding the version decorator to all properties? Or maybe we could add one single call at init class level? |
|
Any comment @SMoraisAnsys ? |
|
@SMoraisAnsys @Samuelopez-ansys FWIW, I had Copilot analyze the version decorator and he (she?) didn't think the implementation would handle it at a class level and recommended adding them for each method. |
|
@jsalant22 Sometimes copilot does not give the most efficient answer. I am waiting @SMoraisAnsys to see his feedback regarding all these decorators |
Add a couple convenience functions to EmitNode to get the node's fullname and it's parent node's name.
Description
Please provide a brief description of the changes made in this pull request.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist