Skip to content

FIX: add EmitNode parent#7303

Merged
Samuelopez-ansys merged 12 commits intomainfrom
FIX-emit-parent
Mar 4, 2026
Merged

FIX: add EmitNode parent#7303
Samuelopez-ansys merged 12 commits intomainfrom
FIX-emit-parent

Conversation

@jsalant22
Copy link
Contributor

@jsalant22 jsalant22 commented Feb 23, 2026

Add a couple convenience functions to EmitNode to get the node's fullname and it's parent node's name.

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

Add a couple convenience functions to EmitNode to get the node's fullname and it's parent node's name.
@jsalant22 jsalant22 requested a review from a team as a code owner February 23, 2026 13:38
@github-actions github-actions bot added the bug Something isn't working label Feb 23, 2026
SMoraisAnsys
SMoraisAnsys previously approved these changes Feb 24, 2026
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a minor comment.

Adds min version decorator to all node methods
@jsalant22
Copy link
Contributor Author

@Samuelopez-ansys @SMoraisAnsys Anything else for this PR?

@SMoraisAnsys
Copy link
Collaborator

@Samuelopez-ansys @SMoraisAnsys Anything else for this PR?

There is a huge conflict it seems

@Samuelopez-ansys
Copy link
Member

@jsalant22 I have fixed all conflict, the root cuase was that you added -> None to all setters, and the setter should not return anything.

@SMoraisAnsys Do you agree adding the version decorator to all properties? Or maybe we could add one single call at init class level?

@Samuelopez-ansys
Copy link
Member

Any comment @SMoraisAnsys ?

@jsalant22
Copy link
Contributor Author

@SMoraisAnsys @Samuelopez-ansys FWIW, I had Copilot analyze the version decorator and he (she?) didn't think the implementation would handle it at a class level and recommended adding them for each method.

@Samuelopez-ansys
Copy link
Member

@jsalant22 Sometimes copilot does not give the most efficient answer. I am waiting @SMoraisAnsys to see his feedback regarding all these decorators

@Samuelopez-ansys Samuelopez-ansys merged commit b8e9756 into main Mar 4, 2026
74 of 75 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the FIX-emit-parent branch March 4, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants