-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: active support for Python 3.13 #1481
Conversation
Missing VTK release compatible with 3.13 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1481 +/- ##
=======================================
Coverage 91.60% 91.60%
=======================================
Files 86 86
Lines 7051 7051
=======================================
Hits 6459 6459
Misses 592 592 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some considerations:
Should we update the main Python version in the CI file?
MAIN_PYTHON_VERSION: '3.12' |
Maybe we could update this link too:
pyansys-geometry/doc/source/conf.py
Line 199 in 9cec7ba
"python": ("https://docs.python.org/3.11", None), |
The docs link was pinned at 3.11 because some of the typehints were giving problems in the past. I'll give it a try to 3.13 overall |
Looks like everything is working well - I have a lot of numpydoc warnings now with 3.13 but I will fix them soon in a follow-up PR. @AlejandroFernandezLuces would you mind approving? |
Description
Provide active support for Python 3.13
Issue linked
None
Checklist
feat: extrude circle to cylinder
)