Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: active support for Python 3.13 #1481

Merged
merged 14 commits into from
Nov 27, 2024
Merged

feat: active support for Python 3.13 #1481

merged 14 commits into from
Nov 27, 2024

Conversation

RobPasMue
Copy link
Member

Description

Provide active support for Python 3.13

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@github-actions github-actions bot added maintenance Package and maintenance related enhancement New features or code improvements labels Oct 15, 2024
@RobPasMue
Copy link
Member Author

Missing VTK release compatible with 3.13

@RobPasMue RobPasMue self-assigned this Oct 16, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.60%. Comparing base (b1a0556) to head (0d1109f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1481   +/-   ##
=======================================
  Coverage   91.60%   91.60%           
=======================================
  Files          86       86           
  Lines        7051     7051           
=======================================
  Hits         6459     6459           
  Misses        592      592           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue marked this pull request as ready for review November 27, 2024 09:48
@RobPasMue RobPasMue requested review from PipKat and a team as code owners November 27, 2024 09:48
Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some considerations:

Should we update the main Python version in the CI file?

MAIN_PYTHON_VERSION: '3.12'

Maybe we could update this link too:

"python": ("https://docs.python.org/3.11", None),

@RobPasMue
Copy link
Member Author

The docs link was pinned at 3.11 because some of the typehints were giving problems in the past. I'll give it a try to 3.13 overall
and see if it works anyway

@RobPasMue
Copy link
Member Author

Looks like everything is working well - I have a lot of numpydoc warnings now with 3.13 but I will fix them soon in a follow-up PR. @AlejandroFernandezLuces would you mind approving?

@RobPasMue RobPasMue merged commit 8d9d805 into main Nov 27, 2024
46 of 48 checks passed
@RobPasMue RobPasMue deleted the feat/py313 branch November 27, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants