-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: matrix rotation and translation #1689
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from my comment, it's looking good. Let's try to improve the rotation testing. Once done, please re-request review and I'll approve.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## blitz #1689 +/- ##
==========================================
- Coverage 91.43% 91.39% -0.05%
==========================================
Files 91 91
Lines 7847 7880 +33
==========================================
+ Hits 7175 7202 +27
- Misses 672 678 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Matrix rotation and translation operations brought by SC Geometry Matrix class
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
feat: extrude circle to cylinder
)