Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: matrix rotation and translation #1689

Merged
merged 5 commits into from
Jan 28, 2025

Conversation

umutsoysalansys
Copy link
Contributor

@umutsoysalansys umutsoysalansys commented Jan 24, 2025

Description

Matrix rotation and translation operations brought by SC Geometry Matrix class

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@umutsoysalansys umutsoysalansys requested a review from a team as a code owner January 24, 2025 18:49
@github-actions github-actions bot added testing Anything related to tests enhancement New features or code improvements labels Jan 24, 2025
@umutsoysalansys umutsoysalansys changed the title matrix rotation and translation feat: matrix rotation and translation Jan 24, 2025
@umutsoysalansys umutsoysalansys self-assigned this Jan 25, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my comment, it's looking good. Let's try to improve the rotation testing. Once done, please re-request review and I'll approve.

src/ansys/geometry/core/math/matrix.py Outdated Show resolved Hide resolved
tests/test_math.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 82.35294% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.39%. Comparing base (9105449) to head (fc775ec).
Report is 1 commits behind head on blitz.

Files with missing lines Patch % Lines
src/ansys/geometry/core/math/matrix.py 82.35% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            blitz    #1689      +/-   ##
==========================================
- Coverage   91.43%   91.39%   -0.05%     
==========================================
  Files          91       91              
  Lines        7847     7880      +33     
==========================================
+ Hits         7175     7202      +27     
- Misses        672      678       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobPasMue RobPasMue enabled auto-merge (squash) January 28, 2025 08:11
@RobPasMue RobPasMue merged commit ab39ca0 into blitz Jan 28, 2025
24 of 27 checks passed
@RobPasMue RobPasMue deleted the feat/matrix_rotation_translation_ops branch January 28, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements testing Anything related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants