Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export and download stride format #1698

Merged
merged 43 commits into from
Jan 28, 2025
Merged

feat: export and download stride format #1698

merged 43 commits into from
Jan 28, 2025

Conversation

b-matteo
Copy link
Contributor

Description

This PR implements the STRIDE format export and download in PyAnsys Geometry. Furthermore the design.download method now uses a more straightforward implementation, still allowing previous backend export and download workflows.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

b-matteo and others added 30 commits January 20, 2025 17:04
Implementing two additional backend types: CORE_WINDOWS and CORE_LINUX
Add export to disco format
Add export to stride format
Refactor download method to only consume one kind of grpc call
Add test for stride export
Add test for disco export
@b-matteo b-matteo self-assigned this Jan 28, 2025
@b-matteo b-matteo requested a review from a team as a code owner January 28, 2025 09:04
@github-actions github-actions bot added the enhancement New features or code improvements label Jan 28, 2025
@b-matteo b-matteo changed the title Feat: export and download stride format feat: export and download stride format Jan 28, 2025
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 82.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 91.17%. Comparing base (1bb39e5) to head (cdca2d9).
Report is 1 commits behind head on blitz.

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/design.py 82.50% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            blitz    #1698      +/-   ##
==========================================
- Coverage   91.33%   91.17%   -0.16%     
==========================================
  Files          91       91              
  Lines        7892     7924      +32     
==========================================
+ Hits         7208     7225      +17     
- Misses        684      699      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

tests/integration/test_design_import.py Show resolved Hide resolved
tests/integration/test_design_import.py Show resolved Hide resolved
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @b-matteo - merging!

@RobPasMue RobPasMue enabled auto-merge (squash) January 28, 2025 13:26
@RobPasMue RobPasMue merged commit 78bde4c into blitz Jan 28, 2025
27 of 28 checks passed
@RobPasMue RobPasMue deleted the feat/download_stride branch January 28, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants