-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export and download stride format #1698
Conversation
Implementing two additional backend types: CORE_WINDOWS and CORE_LINUX Add export to disco format Add export to stride format Refactor download method to only consume one kind of grpc call Add test for stride export Add test for disco export
…ansys-geometry into fix/import_body_locally
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## blitz #1698 +/- ##
==========================================
- Coverage 91.33% 91.17% -0.16%
==========================================
Files 91 91
Lines 7892 7924 +32
==========================================
+ Hits 7208 7225 +17
- Misses 684 699 +15 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @b-matteo - merging!
Description
This PR implements the STRIDE format export and download in PyAnsys Geometry. Furthermore the design.download method now uses a more straightforward implementation, still allowing previous backend export and download workflows.
Checklist
feat: extrude circle to cylinder
)