Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove towncrier info duplicates #1702

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

SMoraisAnsys
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys commented Jan 29, 2025

Description

Information associated to changes of type 'documentation' and 'maintenance' is duplicated.

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

Information associated to changes of type 'documentation' and 'maintenance'
was duplicated.
@SMoraisAnsys SMoraisAnsys requested a review from a team as a code owner January 29, 2025 07:50
@SMoraisAnsys SMoraisAnsys self-assigned this Jan 29, 2025
@github-actions github-actions bot added the maintenance Package and maintenance related label Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.37%. Comparing base (a58c04f) to head (40b7d4f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1702   +/-   ##
=======================================
  Coverage   91.37%   91.37%           
=======================================
  Files          87       87           
  Lines        7143     7143           
=======================================
  Hits         6527     6527           
  Misses        616      616           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch @SMoraisAnsys - thanks!

@RobPasMue RobPasMue enabled auto-merge (squash) January 29, 2025 08:28
@RobPasMue RobPasMue merged commit c5d5426 into main Jan 29, 2025
48 checks passed
@RobPasMue RobPasMue deleted the chore/remove-towncrier-duplicate branch January 29, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants