-
Notifications
You must be signed in to change notification settings - Fork 17
feat: workflow enhancements for better tool results #1723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Implement Enhanced Share Topology. Implement ModfiyCircularPattern.
Note: this PR will fail to build until the ApiServer side implementations are complete: https://tfs.ansys.com:8443/tfs/ANSYS_Development/CASL/_git/ApiServer/pullrequest/559034 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM but I am concerned about code duplication with this PR. Also, we need to start handling quantities and measurement objects properly inside the tools and commands modules... Apart from "Real" we should also be accepting "Quantity" and "Distance"/"Angle" objects... but we can do this in a follow up PR to adapt all of them
Looks like pre-commit is failing - please check the errors locally. My feeling is that there is a missing import statement. Also, all these methods require testing. |
…sys/pyansys-geometry into feat/enhanced_tool_responses_ # Conflicts: # src/ansys/geometry/core/tools/repair_tools.py
…sys/pyansys-geometry into feat/enhanced_tool_responses_ # Conflicts: # src/ansys/geometry/core/tools/repair_tools.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1723 +/- ##
==========================================
+ Coverage 90.84% 90.87% +0.02%
==========================================
Files 92 92
Lines 8152 8198 +46
==========================================
+ Hits 7406 7450 +44
- Misses 746 748 +2 ☔ View full report in Codecov by Sentry. |
Is this PR ready for review? |
@RobPasMue Yeah this should be good to go once we get the Linux Docker image fixed. I think we found the problem |
LGTM! We can merge it if we want. The PR is passing the required checks (even if the latest unstable isn't working, these changes work with the latest stable) |
Description
Implement EnhancedRepairToolMessage.
Implement Enhanced Share Topology.
Implement ModfiyCircularPattern.
Implement FindAndSimplify.
Issue linked
None
Checklist
feat: extrude circle to cylinder
)