Skip to content

feat: workflow enhancements for better tool results #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Feb 14, 2025

Conversation

mlkaplan36
Copy link
Contributor

@mlkaplan36 mlkaplan36 commented Feb 4, 2025

Description

Implement EnhancedRepairToolMessage.
Implement Enhanced Share Topology.
Implement ModfiyCircularPattern.
Implement FindAndSimplify.

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

Implement Enhanced Share Topology.
Implement ModfiyCircularPattern.
@mlkaplan36 mlkaplan36 self-assigned this Feb 4, 2025
@mlkaplan36 mlkaplan36 requested a review from a team as a code owner February 4, 2025 20:28
@github-actions github-actions bot added the enhancement New features or code improvements label Feb 4, 2025
@mlkaplan36
Copy link
Contributor Author

Note: this PR will fail to build until the ApiServer side implementations are complete: https://tfs.ansys.com:8443/tfs/ANSYS_Development/CASL/_git/ApiServer/pullrequest/559034

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM but I am concerned about code duplication with this PR. Also, we need to start handling quantities and measurement objects properly inside the tools and commands modules... Apart from "Real" we should also be accepting "Quantity" and "Distance"/"Angle" objects... but we can do this in a follow up PR to adapt all of them

@mlkaplan36 mlkaplan36 requested a review from RobPasMue February 5, 2025 17:42
@RobPasMue
Copy link
Member

Looks like pre-commit is failing - please check the errors locally. My feeling is that there is a missing import statement. Also, all these methods require testing.

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 90.19608% with 5 lines in your changes missing coverage. Please review.

Project coverage is 90.87%. Comparing base (1439fe4) to head (8f46450).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/tools/repair_tools.py 80.95% 4 Missing ⚠️
src/ansys/geometry/core/tools/prepare_tools.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1723      +/-   ##
==========================================
+ Coverage   90.84%   90.87%   +0.02%     
==========================================
  Files          92       92              
  Lines        8152     8198      +46     
==========================================
+ Hits         7406     7450      +44     
- Misses        746      748       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue
Copy link
Member

Is this PR ready for review?

@RyanJWard
Copy link
Contributor

Is this PR ready for review?

@RobPasMue Yeah this should be good to go once we get the Linux Docker image fixed. I think we found the problem

@RobPasMue
Copy link
Member

LGTM! We can merge it if we want. The PR is passing the required checks (even if the latest unstable isn't working, these changes work with the latest stable)

@RobPasMue RobPasMue enabled auto-merge (squash) February 14, 2025 15:15
@RobPasMue RobPasMue merged commit 585b2e1 into main Feb 14, 2025
52 checks passed
@RobPasMue RobPasMue deleted the feat/enhanced_tool_responses_ branch February 14, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants