Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update CONTRIBUTING.md #1730

Merged
merged 4 commits into from
Feb 6, 2025
Merged

Conversation

SMoraisAnsys
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys commented Feb 6, 2025

Description

The link was missing version. Note that you can also use stable instead of dev 😄

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

The link was missing `version`.
@SMoraisAnsys SMoraisAnsys requested a review from a team as a code owner February 6, 2025 11:00
@SMoraisAnsys SMoraisAnsys self-assigned this Feb 6, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 6, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Feb 6, 2025
@RobPasMue RobPasMue enabled auto-merge (squash) February 6, 2025 11:57
@RobPasMue
Copy link
Member

Thanks @SMoraisAnsys!

@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Feb 6, 2025
@SMoraisAnsys
Copy link
Contributor Author

Thanks @SMoraisAnsys!

That's thanks to @Revathyvenugopal162 who saw that in another repo :D

@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.94%. Comparing base (ad53013) to head (6da0eb4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1730   +/-   ##
=======================================
  Coverage   90.94%   90.94%           
=======================================
  Files          91       91           
  Lines        8006     8006           
=======================================
  Hits         7281     7281           
  Misses        725      725           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue merged commit f79a249 into main Feb 6, 2025
48 checks passed
@RobPasMue RobPasMue deleted the docs/fix-contributing-failing-link branch February 6, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants