Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move command-based bool ops to geometry commands #1731

Closed
wants to merge 3 commits into from

Conversation

RobPasMue
Copy link
Member

Description

It might be interesting to move the boolean operations command-based implementation separately from the boolean ops implemented within the bodies logic. The underlying calls behave differently after looking at them with @b-matteo.

This will allow to support two different behaviors.

Issue linked

Closes #1724

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Feb 6, 2025
@github-actions github-actions bot added the bug Something isn't working label Feb 6, 2025
@RobPasMue RobPasMue closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boolean Intersection not working in all cases
2 participants