Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1953 +/- ##
==========================================
- Coverage 88.44% 87.37% -1.08%
==========================================
Files 90 90
Lines 10276 10266 -10
==========================================
- Hits 9089 8970 -119
- Misses 1187 1296 +109 |
7f1efc2 to
8a796f2
Compare
8a796f2 to
b6d27b1
Compare
|
Checking the decrease in coverage. Some tests were duplicated and exactly the same. |
a9cd044 to
cf892ad
Compare
There was a problem hiding this comment.
This test slightly differs from another named exactly the same within this file. To be reviewed...
cf892ad to
05c4f74
Compare
|
Progress on this for the next days:
This solves the issues for coverage and codacy. Example: mesh = Object.mesh
assert np.assert_allclose(mesh, mesh_expected, atol, rtol) |
|
I do not see how we can boost coverage on the erring lines. Most are modified f-strings or exception statements. If the lines are really being covered before now, there is no reason why they shouldn't be covered after the changes, at least I can't think of any. |
|
@jorgepiloto , just a reminder that I think we can merge this? |
|
Hi @jorgepiloto, hi @moe-ad is this still active? Should it be marked as ready-for-review? |
|
Hi @moe-ad @jorgepiloto I'll close the PR as stale. You can reopen on start a new one based on what was proposed here. |
This is related with #296. It enables the PyFlakes (F) rule. Most of the changes include:
__all__in__init__files