Skip to content

Test the FieldHeader getter operator #2348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

rafacanton
Copy link
Contributor

@rafacanton rafacanton commented Jun 6, 2025

A new operator has been added to be able to get the Header of a Field as a DataTree. This PR exposes and tests its getter

@rafacanton rafacanton self-assigned this Jun 6, 2025
@rafacanton rafacanton added tests Related to tests enhancement New feature or request labels Jun 6, 2025
@rafacanton
Copy link
Contributor Author

This now fails as the server is not up-to-date. It passes with the right server: #2344

@rafacanton rafacanton requested a review from PProfizi June 6, 2025 14:40
Copy link
Contributor

github-actions bot commented Jun 6, 2025

The documentation for this pull request will be available at https://dpf.docs.pyansys.com/pull/2348. Please allow some time for the documentation to be deployed.

Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.11%. Comparing base (1095ea2) to head (e6a9aa7).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2348      +/-   ##
==========================================
+ Coverage   84.10%   84.11%   +0.01%     
==========================================
  Files          91       91              
  Lines       10529    10538       +9     
==========================================
+ Hits         8855     8864       +9     
  Misses       1674     1674              

@rafacanton rafacanton requested a review from Sangsimon June 11, 2025 14:08
@rafacanton rafacanton marked this pull request as draft June 11, 2025 14:28
@rafacanton
Copy link
Contributor Author

@Sangsimon Putting this work on hold so it can be more generic. I think this should fall on the Header exposure you will be working on. TODOs:

  • Expose a similar operator for StringFields (I don't know why I didn't do it, all pieces are there)
  • Expose the header getter here in the FieldBase class so all it children redirect the call to the appropriate op

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants