Skip to content

Add tablemapREST Class for Table Expression Generator and Fix Issues in tablereduceREST #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 28, 2025

Conversation

ompat5
Copy link
Collaborator

@ompat5 ompat5 commented Jul 23, 2025

This PR introduces the following changes:

Added tablemapREST Class:

  • Implemented the tablemapREST class to support the table expression generator.
  • Integrated the new generator into relevant sections, such as serverless, GENERATOR_TYPES and other constants.

Fixed Issues in tablereduceREST:

  • Corrected a bug where d["reduce_params"] was mistakenly referenced as d.
  • Fixed an issue where del sources[i] was used without defining i.

Updated Version:

  • Changed the version from dev0 to dev1 to ensure compatibility with teammates' ongoing changes.

User Story: https://tfs.ansys.com:8443/tfs/ANSYS_Development/Portfolio/_workitems/edit/1289662

@ompat5 ompat5 requested a review from margalva July 23, 2025 14:27
@ompat5 ompat5 self-assigned this Jul 23, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2025

Codecov Report

❌ Patch coverage is 87.14286% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.17%. Comparing base (95104c0) to head (e5e8e57).

Files with missing lines Patch % Lines
...nsys/dynamicreporting/core/utils/report_objects.py 86.86% 4 Missing and 14 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
+ Coverage   80.91%   81.17%   +0.25%     
==========================================
  Files          26       26              
  Lines        7367     7504     +137     
  Branches     1366     1404      +38     
==========================================
+ Hits         5961     6091     +130     
+ Misses        981      973       -8     
- Partials      425      440      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ompat5 ompat5 marked this pull request as ready for review July 23, 2025 16:50
@ompat5 ompat5 requested a review from viseshrp as a code owner July 23, 2025 16:50
@ompat5 ompat5 requested a review from viseshrp July 28, 2025 15:40
@viseshrp viseshrp merged commit c87a72a into main Jul 28, 2025
19 checks passed
@viseshrp viseshrp deleted the om/clean-math-exp-gen branch July 28, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants