FEATURE: Auto select server port #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test that demonstrates the failure when the default port 50051 is already in use.
Add a function `_find_available_port` to find a port in the range [50051, 60000] that is available to open a listening socket on. Use this function to automatically select a port when either `launch_session` or `session` are used to launch a gRPC server session and `port_num` is `None` (the default).
isaacwaldron
commented
Jan 10, 2025
drewm102
approved these changes
Jan 16, 2025
chenchienjacklin
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a function
_find_available_portto find a port in the range [50051, 60000] that is available to open a listening socket on. Use this function to automatically select a port when eitherlaunch_sessionorsessionare used to launch a gRPC server sessionand
port_numisNone(the default).Closes #478