fix: chown server-info file by client user in compose mode #4483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
requested review from
hpohekar,
mayankansys,
prmukherj and
seanpearsonuk
as code owners
|
@hpohekar Please verify these changes from your side. I got the test I was trying to execute the chown as a separate |
mkundu1
commented
Sep 19, 2025
|
|
||
| container_dict["command"].append( | ||
| f"""-command="(system \\\"chown {os.getuid()}:{os.getgid()} {container_dict["container_server_info_file"]}\\\")" """ | ||
| ) |
There was a problem hiding this comment.
This will send the scheme command (system "chown <uid>:<gid> <server-info-file>") to Fluent.
|
Superseded by #4484 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
FLUENT_SERVER_INFO_PERMISSION_SYSTEMenv var for compose launch. The server writes the server-info file with the default 600 permission. The file is then owned by client-user via a subsequent scheme command, so it can be read in the client side.