fix: Implement migration adapter check for textual settings parameters. #4515
+41
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prmukherj
requested review from
mkundu1,
seanpearsonuk,
hpohekar and
mayankansys
as code owners
|
The description! |
Co-authored-by: Sean Pearson <[email protected]>
Done, Thank you |
seanpearsonuk
approved these changes
Oct 3, 2025
|
@prmukherj Can you please add a test? |
yes, sure, will add one before merging. Thank you for mentioning it. |
@mkundu1, added the test mentioned in the fluent bug with a different case file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1293534
If migration adapter is in place then we bypass this type checking and let it fall to settings-api directly where it handles the input and does the necessary updates.
For example:
This takes a string as input, but it also has a migration adapter which takes a bool and assigns a string value accordingly from settings-api. So, in this case, pyfluent should not throw a Type error but accept the value and pass it on to settings-api.
This is fixed w.r.t. a Fluent side bug as mentioned as of now, later we have to implement the logic deeper.