Skip to content

FIX: Relative path for saving #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

FIX: Relative path for saving #1253

wants to merge 2 commits into from

Conversation

dipinknair
Copy link
Collaborator

Currently for App.save() or save_as needs absolute path. This PR looks into possibility of saving file to current working directory if relative path is provided.

Fixes #211

@github-actions github-actions bot added the bug Something isn't working label Jul 23, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 23, 2025
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.15% (target: -1.00%) 55.56%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d2101ec) 2557 2197 85.92%
Head commit (4d2480d) 2566 (+9) 2201 (+4) 85.78% (-0.15%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1253) 9 5 55.56%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Copy link

codecov bot commented Jul 23, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.77%. Comparing base (d2101ec) to head (4d2480d).

❌ Your patch check has failed because the patch coverage (55.55%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1253      +/-   ##
==========================================
- Coverage   85.92%   85.77%   -0.15%     
==========================================
  Files          39       39              
  Lines        2557     2566       +9     
==========================================
+ Hits         2197     2201       +4     
- Misses        360      365       +5     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app.save() and ExtAPI.Graphics.ExportImage don't work with a filename that doesn't include a path
2 participants