feat: refactor source class #690
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #690 +/- ##
==========================================
+ Coverage 88.90% 89.07% +0.16%
==========================================
Files 39 39
Lines 5617 5904 +287
==========================================
+ Hits 4994 5259 +265
- Misses 623 645 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pluAtAnsys
requested review from
StefanThoene,
echambla and
jomadec
as code owners
|
@SMoraisAnsys @echambla @StefanThoene Could you please review the refactor methods |
|
cheat sheet need to be adjusted |
| @@ -106,6 +110,129 @@ def __init__( | |||
| self.source_template_link = self._project.client[source_instance.source_guid] | |||
| self._reset() | |||
|
|
|||
| class Luminous: | |||
There was a problem hiding this comment.
Generate A flux class.
has a property value and a set luminous and set radiant value
what do you think about that?
There was a problem hiding this comment.
by default it is luminous if you use the set radiant value it take sthe current value and puts ist to radiant and dependdant on the state the value setter works.
i think user experience would be better
There was a problem hiding this comment.
Creating a Flux class is an idea
I see also the property value that you mention.
Regarding the set luminous and set radiant, will they be properties or methods?
Also in this case it is important to think at the possibility from_intensity_file / from_ray_file
Where you thinking at something like that?
There was a problem hiding this comment.
Another possibility that would avoid having to create a new Flux class:
With this, we could use the fact that the three properties are all starting with "flux_" to give the user an indication that he has to pick up one of these three properties to define the flux.
| @@ -846,6 +1049,151 @@ class SourceSurface(BaseSource): | |||
| Uses default values when True. | |||
| """ | |||
|
|
|||
| class Intensity: | |||
There was a problem hiding this comment.
include in flux class?
There was a problem hiding this comment.
or add through inheritance
Co-authored-by: Stefan Thöne <[email protected]>
Co-authored-by: Stefan Thöne <[email protected]>
Co-authored-by: Stefan Thöne <[email protected]>
Co-authored-by: Stefan Thöne <[email protected]>
Co-authored-by: Stefan Thöne <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Stefan Thöne <[email protected]>
github-actions
bot
added
the
documentation
Description
need some testing and proper definition
Add properties to SourceLuminaire:
add properties to SourceRayfile:
add properties to SourceSurface
Issue linked
Refactor source #684
Checklist
feat: add optical property)