Skip to content

Conversation

SMoraisAnsys
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys commented Aug 26, 2025

Description

Since comtypes.client.CreateObject is only used for windows, it would be great to only install it on that platform. Strange behavior have been detected on another workflow when using pyspeos on other system, e.g. Github's runner ubuntu-22.04.

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@SMoraisAnsys SMoraisAnsys self-assigned this Aug 26, 2025
@github-actions github-actions bot added the maintenance Package and maintenance related label Aug 26, 2025
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.90%. Comparing base (89457c1) to head (2e27f25).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #704   +/-   ##
=======================================
  Coverage   88.90%   88.90%           
=======================================
  Files          39       39           
  Lines        5617     5617           
=======================================
  Hits         4994     4994           
  Misses        623      623           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@StefanThoene StefanThoene merged commit 129bdf0 into main Aug 29, 2025
24 checks passed
@StefanThoene StefanThoene deleted the build/update-dependency-based-on-arch branch August 29, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants