Skip to content

Conversation

@pluAtAnsys
Copy link
Collaborator

@pluAtAnsys pluAtAnsys commented Oct 25, 2025

Description

Develop pyspeos to connect to the recently developed VBB in Speos RPC.

Issue linked

VBB high demand #706

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@pluAtAnsys pluAtAnsys self-assigned this Oct 25, 2025
@pluAtAnsys pluAtAnsys added enhancement New features or code improvements documentation Improvements or additions to documentation testing Anything related to tests labels Oct 25, 2025
@pluAtAnsys pluAtAnsys linked an issue Oct 25, 2025 that may be closed by this pull request
@pluAtAnsys pluAtAnsys changed the title Feat/add virtual bsdf bench feat: add virtual bsdf bench Oct 25, 2025
@pluAtAnsys pluAtAnsys changed the title feat: add virtual bsdf bench feat: add supporting virtual bsdf bench Oct 25, 2025
@codecov
Copy link

codecov bot commented Oct 25, 2025

Codecov Report

❌ Patch coverage is 84.75073% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.48%. Comparing base (d262cd9) to head (ea8526f).

Files with missing lines Patch % Lines
src/ansys/speos/core/simulation.py 84.77% 51 Missing ⚠️
src/ansys/speos/core/project.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #763      +/-   ##
==========================================
- Coverage   88.99%   88.48%   -0.51%     
==========================================
  Files          39       39              
  Lines        5653     5994     +341     
==========================================
+ Hits         5031     5304     +273     
- Misses        622      690      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pluAtAnsys pluAtAnsys marked this pull request as ready for review November 4, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New features or code improvements testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VBB high demand

3 participants