Zoom feature #61
Open
Zoom feature #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demo.mp4This is from web server side. if developer wants to add zoom out or in features they can. because one can give a frame to videoCapturer so it will crop that portion and sends to the server and it looks like zooming something. |
|
hi @MuhammadjonTohirov , Thank you for the implementation. I have had a review for this PR. We can use this functionality in the SDK for sure. We want to control the zoom of the camera. Your current implementation makes sense and we can use for screensharing.
If you need further clarity, let me know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zoom feature, that allows user to select portion of the screen and crops frames while streaming buffers.
It works only in
RTCCustomFrameCapturer.