Use index operation instead of create #130
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using index instead of create allows to not specify an ID
Using the index operation instead of create allows the omission of the ID field.
added 2 commits
September 10, 2024 16:29
The method checking the version was doing a check on a "distribution" element that was not always there. However it didn't handle the case where it was not there and defaulted to version "-1".
|
Thanks @Yutsa . Your fix helped a lot for integration with OpenSearch! |
|
@Yutsa - The issue with changing the operation to index is that it breaks functionality for DataStream type indexes when using Elastic Elasticsearch. The op change to We may need a configuration option that allows the user that is using the tool to determine whether they want to use a create or an index operation. Another option might be to make this value dynamic dependent on the distribution - use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the index operation instead of create allows the omission of the ID field.
This makes the listener work with ES > 5.0