Skip to content

Initial GitHub Workflow and Infection setup#16

Open
peter279k wants to merge 1 commit intoantidot-framework:1.x.xfrom
open-source-contributions:improve_stuffs
Open

Initial GitHub Workflow and Infection setup#16
peter279k wants to merge 1 commit intoantidot-framework:1.x.xfrom
open-source-contributions:improve_stuffs

Conversation

@peter279k
Copy link
Member

Description

  • Initial GitHub Workflow and Infection setup.
  • Removing PHPStan setting because this ignored error is not presented anymore.

Motivation and context

N/A

How has this been tested?

N/A

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

@peter279k peter279k requested a review from kpicaza November 18, 2021 11:19
@peter279k peter279k self-assigned this Nov 18, 2021
Copy link
Member

@kpicaza kpicaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as in template-renderer, we can add support for both PHP 7.4 and 8.0 from the beginning. Thanks again ;-D

dependencies:
- "locked"
php-version:
- "7.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "7.4"
- "7.4"
- "8.0"

dependencies:
- "locked"
php-version:
- "7.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "7.4"
- "7.4"
- "8.0"

dependencies:
- "locked"
php-version:
- "7.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "7.4"
- "7.4"
- "8.0"

dependencies:
- "locked"
php-version:
- "7.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "7.4"
- "7.4"
- "8.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants