feat(agent): add ProfileCollectionConfig for eBPF profiler #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds ProfileCollectionConfig proto message to enable config-driven profiler activation. Design uses single event per profiler instance for simplicity. Fields: - event_name: Perf event to sample (cpu-cycles, cpu-clock, etc.) - sample_period: Sample frequency (cycles or nanoseconds) - interval_seconds: Profile aggregation interval - max_stack_depth: Stack trace depth limit (future) - process_filters: Process filtering (future) Related: system-agent ENG-2262, GitHub issue #235
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ProfileCollectionConfig proto message to enable disk-based profiler configuration in system-agent.
Design: Single event per profiler instance for simplicity and clarity.
Fields:
event_name: Perf event to sample (cpu-cycles, cpu-clock, etc.) - Requiredsample_period: Sample frequency (cycles or nanoseconds) - Optional, smart defaultsinterval_seconds: Profile aggregation interval - Optional, default 60smax_stack_depth: Stack trace depth limit - Future useprocess_filters: Process filtering - Future useUsage: Enables LLM-generated configs for automated profiler activation.
Related: