-
Notifications
You must be signed in to change notification settings - Fork 49
fix: update-snapshots #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @moayuisuda, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates existing integration test snapshots for linear axis label rendering. The changes reflect modifications to the positioning and interactivity of Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates test snapshots for axis label rendering. The changes introduce horizontal centering for HTML-based labels, which is a good improvement. My review includes a suggestion to also implement vertical centering for consistency. Overall, this is a positive change that improves label rendering.
| <g fill="none" class="axis-label" transform="matrix(1 0 0 1 50 55)"> | ||
| <g> | ||
| <foreignObject width="112.5" height="30" class="axis-label-item" style="text-align: center; direction: positive;"> | ||
| <foreignObject width="112.5" height="30" x="-56.25" class="axis-label-item" style="pointer-events: auto; text-align: center; direction: positive;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change correctly centers the HTML label horizontally by setting the x attribute, which is a great improvement. However, the vertical centering seems to have been overlooked. For consistent and predictable label placement, I suggest also adjusting the y attribute based on the label's height in the rendering logic (e.g., y = y - height / 2). This would ensure labels are fully centered on their anchor point, which is especially important for multi-line HTML labels.
No description provided.