Remove has_new_vote_been_rooted and voted_signatures #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix master errors (anza-xyz#52)
PohService needs to set `use_alpenglow_tick_producer` flag on startup (anza-xyz#59)
Co-authored-by: yihau <[email protected]> Co-authored-by: carllin <[email protected]> Co-authored-by: Ashwin Sekar <[email protected]>
…all fashion. (anza-xyz#69) Co-authored-by: yihau <[email protected]> Co-authored-by: carllin <[email protected]> Co-authored-by: Ashwin Sekar <[email protected]>
Co-authored-by: carllin <[email protected]>
Co-authored-by: carllin <[email protected]>
wen-coding
reviewed
Jul 7, 2025
| if !has_new_vote_been_rooted { | ||
| info!("Haven't landed a vote, so skipping my leader slot"); | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
Wait, I think we will also use the Alpenglow repo to test migration code later, so shouldn't we try to not touch TowerBFT code?
Also, the transition from transaction to BLS message hasn't happened yet, I'm trying to do it in #214
Contributor
|
@0xPraedico These checks should only be removed from the voting and block creation loop. Please leave replay stage untouched. Thanks! |
AshwinSekar
reviewed
Jul 7, 2025
| return Err(StartLeaderError::StartupVerificationIncomplete(parent_slot)); | ||
| } | ||
|
|
||
| // TODO(ashwin): plug this in from replay |
Contributor
There was a problem hiding this comment.
lets also remove wait_for_vote_to_start_leader from this file
| } else { | ||
| context.voted_signatures.clear(); | ||
| } | ||
| // No-op: we don't store voted_signatures anymore |
Contributor
There was a problem hiding this comment.
Remove this comment, and lets also remove has_new_vote_been_rooted and voted_signatures from the voting context
|
Is this PR still needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
With Alpenglow votes don't actually land as transactions on chain. These checks are obsolete.
Summary of Changes
Fixes #237