wip: register new block ids #686
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@AshwinSekar: did you have something like this in mind for addressing #486? |
AshwinSekar
reviewed
Jan 19, 2026
| .unwrap() | ||
| .get(new_root) | ||
| .expect("Root bank doesn't exist"); | ||
| root_bank.register_recent_blockhash(block_id, &BankWithScheduler::no_scheduler_available()); |
Contributor
There was a problem hiding this comment.
this is not the correct place to do it, we need to be registering the blockhash when we replay the end of the block.
This is currently done via register_tick. Alpenglow blocks still have one fake tick at the end so I think this is a good place to do it:
- If it's a TowerBFT block, use the tick's hash as the blockhash
- If it's an Alpenglow block, we need
register_tickto instead use theblock_id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to address #486, on how we could use block ids in various places instead of block hashes with Alpenglow.